Skip to content

[pigeon] Kotlin InstanceManager doesn't properly remove callbacks from handler #166780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bparrishMines opened this issue Apr 8, 2025 · 0 comments · May be fixed by flutter/packages#9034
Open
Assignees
Labels
p: pigeon related to pigeon messaging codegen tool P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team

Comments

@bparrishMines
Copy link
Contributor

bparrishMines commented Apr 8, 2025

What package does this bug report belong to?

pigeon

Affected Plugins that use pigeon: webview_flutter_android, interactive_media_ads

What target platforms are you seeing this bug on?

Android/Kotlin

Steps to reproduce

This is generated by using @proxyapi feature from pigeon.

Expected results

The InstanceManager contains:

fun stopFinalizationListener() {
    handler.removeCallbacks { this.releaseAllFinalizedInstances() }
    hasFinalizationListenerStopped = true
}

Instead of passing the Runnable that should be removed to handler.removeCallbacks, this is creating a new Runnable and not removing anything.

@bparrishMines bparrishMines added package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team p: pigeon related to pigeon messaging codegen tool P1 High-priority issues at the top of the work list labels Apr 8, 2025
@bparrishMines bparrishMines self-assigned this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: pigeon related to pigeon messaging codegen tool P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant