Skip to content

Commit 3b6170f

Browse files
[google_sign_in] Remove use of OCMock (#10290)
Wraps Google Sign In SDK classes with protocols, so that we can inject fakes that implement the protocols instead of using OCMock to mock the actual classes. This will allow conversion of the tests to Swift, in preparation for migrating the entire plugin to Swift. For now the protocols are implemented in production with passthrough wrappers, so this adds a fair amount of boilerplate code to the plugin, but almost all of it will be removed when the plugin implementation is converted to Swift since we will be able to use extensions to make the SDK classes conform to the protocol instead of maintaining wrappers. Unblocks flutter/flutter#119103 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 0718bf1 commit 3b6170f

File tree

12 files changed

+985
-333
lines changed

12 files changed

+985
-333
lines changed

packages/google_sign_in/google_sign_in_ios/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 6.2.3
2+
3+
* Internal restructuring to improve testability.
4+
15
## 6.2.2
26

37
* Updates minimum supported version to iOS 13.

0 commit comments

Comments
 (0)