Skip to content

Commit 0718bf1

Browse files
[interactive_media_ads] Pin iOS dependency maximum (#10349)
GoogleInteractiveMediaAds [released 3.28.10](googleads/swift-package-manager-google-interactive-media-ads-ios@7f38970) which dropped iOS 13 and 14, breaking our tree. This sets a max version on the dependency to avoid picking up a version that is not compatible with our wrapper's iOS version support. Longer term we can explore expanding the range, but this is non-trivial for Swift Package Manager, so this is the simplest way to fix the tree and clients in the short term. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 5fc2fd7 commit 0718bf1

File tree

6 files changed

+12
-5
lines changed

6 files changed

+12
-5
lines changed

packages/interactive_media_ads/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.3.0+4
2+
3+
* Sets a maximum version on the `GoogleInteractiveMediaAds` dependency to avoid
4+
breaking iOS 13-14 support.
5+
16
## 0.3.0+3
27

38
* Bumps `com.google.ads.interactivemedia.v3:interactivemedia` from 3.37.0 to 3.38.0.

packages/interactive_media_ads/android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class AdsRequestProxyApi(override val pigeonRegistrar: ProxyApiRegistrar) :
2121
*
2222
* This must match the version in pubspec.yaml.
2323
*/
24-
const val pluginVersion = "0.3.0+3"
24+
const val pluginVersion = "0.3.0+4"
2525
}
2626

2727
override fun setAdTagUrl(pigeon_instance: AdsRequest, adTagUrl: String) {

packages/interactive_media_ads/ios/interactive_media_ads.podspec

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ Downloaded by pub (not CocoaPods).
1616
s.source = { :http => 'https://github.com/flutter/packages/tree/main/packages/interactive_media_ads/interactive_media_ads' }
1717
s.source_files = 'interactive_media_ads/Sources/interactive_media_ads/**/*.swift'
1818
s.dependency 'Flutter'
19-
s.dependency 'GoogleAds-IMA-iOS-SDK', '~> 3.23'
19+
# 3.28.10 requires iOS 15+.
20+
s.dependency 'GoogleAds-IMA-iOS-SDK', '>= 3.23', '< 3.28.10'
2021
s.platform = :ios, '13.0'
2122

2223
# Flutter.framework does not contain a i386 slice.

packages/interactive_media_ads/ios/interactive_media_ads/Package.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ let package = Package(
1818
dependencies: [
1919
.package(
2020
url: "https://github.com/googleads/swift-package-manager-google-interactive-media-ads-ios",
21-
.upToNextMajor(from: "3.23.0"))
21+
// 3.28.10 requires iOS 15+.
22+
"3.23.0"..<"3.28.10")
2223
],
2324
targets: [
2425
.target(

packages/interactive_media_ads/ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class AdsRequestProxyAPIDelegate: PigeonApiDelegateIMAAdsRequest {
1313
/// The current version of the `interactive_media_ads` plugin.
1414
///
1515
/// This must match the version in pubspec.yaml.
16-
static let pluginVersion = "0.3.0+3"
16+
static let pluginVersion = "0.3.0+4"
1717

1818
func pigeonDefaultConstructor(
1919
pigeonApi: PigeonApiIMAAdsRequest, adTagUrl: String, adDisplayContainer: IMAAdDisplayContainer,

packages/interactive_media_ads/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: interactive_media_ads
22
description: A Flutter plugin for using the Interactive Media Ads SDKs on Android and iOS.
33
repository: https://github.com/flutter/packages/tree/main/packages/interactive_media_ads
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+interactive_media_ads%22
5-
version: 0.3.0+3 # This must match the version in
5+
version: 0.3.0+4 # This must match the version in
66
# `android/src/main/kotlin/dev/flutter/packages/interactive_media_ads/AdsRequestProxyApi.kt` and
77
# `ios/interactive_media_ads/Sources/interactive_media_ads/AdsRequestProxyAPIDelegate.swift`
88

0 commit comments

Comments
 (0)