-
Notifications
You must be signed in to change notification settings - Fork 1.4k
metrics: enable input metrics by default #4966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d231091
to
fc546e9
Compare
fc546e9
to
ff5c4b8
Compare
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
ff5c4b8
to
0c76db6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pleased this feature to be enabled by default. Thank you for your work! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to add some tests to check if the option for disabling the feature works intendedly.
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Thanks! fluentd/test/test_supervisor.rb Line 57 in a3f4c82
|
Signed-off-by: Shizuo Fujita <[email protected]>
8f2f8ae
to
b53d79f
Compare
Co-authored-by: Daijiro Fukuda <[email protected]> Signed-off-by: Shizuo Fujita <[email protected]>
301c625
to
9d06878
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
I ran fluend with
--enable-input-metrics
option and read 10GB file with thein_tail
pluginThere was no significant performance degradation.
So, I think it is safe to always enable
--enable-input-metrics
.environment
results
ruby bin/fluentd -c in_tail.conf
ruby bin/fluentd --enable-input-metrics -c in_tail.conf
ruby bin/fluentd -c in_tail.conf
config
script to generate 10GB
Docs Changes:
fluent/fluentd-docs-gitbook#578
Release Note:
The same as the title.