Skip to content

Added the ability to set Use_Tag_For_Meta on fluentbit kubernetes filter #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

solidDoWant
Copy link
Contributor

What this PR does / why we need it:

This tag is missing from the fluentbit filter CRD.

Which issue(s) this PR fixes:

N/A

Does this PR introduced a user-facing change?

Added the ability to set `Use_Tag_For_Meta` on fluentbit kubernetes filter

Additional documentation, usage docs, etc.:

N/A

@solidDoWant solidDoWant force-pushed the feat/add-tag-for-meta-kube-filter-1 branch from 2d312a1 to 5eea60c Compare April 15, 2025 04:47
@cw-Guo cw-Guo self-requested a review April 15, 2025 05:18
cw-Guo
cw-Guo previously approved these changes Apr 15, 2025
@solidDoWant solidDoWant force-pushed the feat/add-tag-for-meta-kube-filter-1 branch from 5eea60c to 20627f9 Compare April 15, 2025 05:24
@solidDoWant
Copy link
Contributor Author

screwed up my rebase, fixing now

@solidDoWant
Copy link
Contributor Author

Actually it looks like I didn't. This looks like a regression related with this revert commit. The controller-gen annotation is now updated when calling make manifests, and the makefile now installs a package that it shouldn't.

I'll file another PR with only make manifests to fix this.

@solidDoWant
Copy link
Contributor Author

I'll regenerate the manifests once #1568 lands, which should fix the diff issue on this and the other PRs

@solidDoWant solidDoWant force-pushed the feat/add-tag-for-meta-kube-filter-1 branch from 20627f9 to e3be6e3 Compare April 17, 2025 06:05
@solidDoWant
Copy link
Contributor Author

solidDoWant commented Apr 17, 2025

@cw-Guo I've rebased all my PRs as requested. I also ran make generate docs-update manifests, added the auto-generated files that I was previously missing, and squashed them into one commit. I think all my PRs should be ready for review. If there's anything I can do to make reviewing and merging easier (such as cherry-picking all the PRs into one larger one), please let me know.

There are a handful of other fields missing from various input/filter/output resource specs that I may open PR(s) for. If I do, would you prefer one single larger PR, or several smaller ones?

@cw-Guo
Copy link
Collaborator

cw-Guo commented Apr 17, 2025

Hi @solidDoWant Thanks again for the contributions. Small pull requests are prefered. Maybe we can group the changes by plugin. All missing fields can be added in a single pull request.

@cw-Guo cw-Guo merged commit 3d63aff into fluent:master Apr 17, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants