Skip to content

Support for Compress option in fb Output forward plugin #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Support for Compress option in fb Output forward plugin #1493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4687b59
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
8cd995d
Update fluentbit.fluent.io_clusteroutputs.yaml
devBmc Mar 6, 2025
bf46472
support for compress in forward output plugin
devBmc Mar 6, 2025
5e46b5b
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
25e8867
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
2d0e0db
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
1bcc9b5
support for Compress in forward output plugin
Mar 7, 2025
cfd236d
text change Signed-off-by: Ravi Ghosh <[email protected]>
Mar 7, 2025
9826811
fix typo
Mar 7, 2025
38076f9
adding signoff
Mar 8, 2025
0215125
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
c594a0c
Update fluentbit.fluent.io_clusteroutputs.yaml
devBmc Mar 6, 2025
18846bb
support for compress in forward output plugin
devBmc Mar 6, 2025
517c25a
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
b9b7de4
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
43fbe31
support for Compress in Forward Output Plugin
devBmc Mar 6, 2025
b41f54c
support for Compress in forward output plugin
Mar 7, 2025
645f576
text change Signed-off-by: Ravi Ghosh <[email protected]>
Mar 7, 2025
49467d3
fix typo
Mar 7, 2025
e14ab29
adding signoff
Mar 8, 2025
ee21d73
Merge branch 'master' of https://github.com/devBmc/fluent-operator
Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apis/fluentbit/v1alpha2/plugins/output/forward_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
// Enables at-least-once and receiving server can control rate of traffic.
// (Requires Fluentd v0.14.0+ server)
RequireAckResponse *bool `json:"requireAckResponse,omitempty"`
// Set payload compression mechanism. Option available is 'gzip'
// +kubebuilder:validation:Enum=gzip
Compress string `json:"compress,omitempty"`
// A key string known by the remote Fluentd used for authorization.
SharedKey string `json:"sharedKey,omitempty"`
// Use this option to connect to Fluentd with a zero-length secret.
Expand Down Expand Up @@ -70,6 +73,9 @@
if f.RequireAckResponse != nil {
kvs.Insert("Require_ack_response", fmt.Sprint(*f.RequireAckResponse))
}
if f.Compress != nil {

Check failure on line 76 in apis/fluentbit/v1alpha2/plugins/output/forward_types.go

View workflow job for this annotation

GitHub Actions / Binary build 

invalid operation: f.Compress != nil (mismatched types string and untyped nil)

Check failure on line 76 in apis/fluentbit/v1alpha2/plugins/output/forward_types.go

View workflow job for this annotation

GitHub Actions / Basic test and verify 

invalid operation: f.Compress != nil (mismatched types string and untyped nil)
kvs.Insert("Compress", fmt.Sprint(*f.Compress))

Check failure on line 77 in apis/fluentbit/v1alpha2/plugins/output/forward_types.go

View workflow job for this annotation

GitHub Actions / Binary build 

invalid operation: cannot indirect f.Compress (variable of type string)

Check failure on line 77 in apis/fluentbit/v1alpha2/plugins/output/forward_types.go

View workflow job for this annotation

GitHub Actions / Basic test and verify 

invalid operation: cannot indirect f.Compress (variable of type string)
}
Comment on lines +76 to +78
Copy link
Collaborator

@marcofranssen marcofranssen Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devBmc Please run following to resolve the merge conflicts and fix the DCO.

$ git checkout master
$ git pull upstream master --rebase --signoff

During conflict resolution ensure to take current.

Then add following for your newly added field.

Once done we can merge this PR.

Suggested change
if f.Compress != nil {
kvs.Insert("Compress", fmt.Sprint(*f.Compress))
}
plugins.InsertKVString(kvs, "Compress", f.Compress)

if f.SharedKey != "" {
kvs.Insert("Shared_Key", f.SharedKey)
}
Expand Down
6 changes: 6 additions & 0 deletions charts/fluent-operator/charts/fluent-bit-crds/crds/fluentbit.fluent.io_clusteroutputs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,12 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available
is 'gzip'
enum:
- gzip
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down
6 changes: 6 additions & 0 deletions charts/fluent-operator/charts/fluent-bit-crds/crds/fluentbit.fluent.io_outputs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,12 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available
is 'gzip'
enum:
- gzip
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down
6 changes: 6 additions & 0 deletions config/crd/bases/fluentbit.fluent.io_clusteroutputs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,12 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available
is 'gzip'
enum:
- gzip
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down
6 changes: 6 additions & 0 deletions config/crd/bases/fluentbit.fluent.io_outputs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,12 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available
is 'gzip'
enum:
- gzip
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down
1 change: 1 addition & 0 deletions docs/plugins/fluentbit/output/forward.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Forward is the protocol used by Fluentd to route messages between peers. <br />
| tag | Overwrite the tag as we transmit. This allows the receiving pipeline start fresh, or to attribute source. | string |
| timeAsInteger | Set timestamps in integer format, it enable compatibility mode for Fluentd v0.12 series. | *bool |
| sendOptions | Always send options (with \"size\"=count of messages) | *bool |
| compress | Set payload compression mechanism. Option available is 'gzip' | string |
| requireAckResponse | Send \"chunk\"-option and wait for \"ack\" response from server. Enables at-least-once and receiving server can control rate of traffic. (Requires Fluentd v0.14.0+ server) | *bool |
| sharedKey | A key string known by the remote Fluentd used for authorization. | string |
| emptySharedKey | Use this option to connect to Fluentd with a zero-length secret. | *bool |
Expand Down
11 changes: 11 additions & 0 deletions manifests/setup/fluent-operator-crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5196,6 +5196,12 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available
is 'gzip'
enum:
- gzip
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down Expand Up @@ -34026,6 +34032,11 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available is 'gzip'
enum:
- gzip
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down
10 changes: 10 additions & 0 deletions manifests/setup/setup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5196,6 +5196,10 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available
is 'gzip'
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down Expand Up @@ -34026,6 +34030,12 @@ spec:
maximum: 65535
minimum: 1
type: integer
compress:
description: Set payload compression mechanism. Option available
is 'gzip'
enum:
- gzip
type: string
requireAckResponse:
description: |-
Send "chunk"-option and wait for "ack" response from server.
Expand Down
Loading