[COM-12898] Make sure to update source when integrating #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turran
force-pushed
the
update_on_integrate
branch
from
9a1cd0c to
f859903
Compare
turran
changed the title
Integrate means that a feature has landed upstream. We must use 'upstream' instead of 'source' as we need to fetch the latest, integrated, changes. If we do so, 'source' will be outdated, so we need to update it too.
turran
force-pushed
the
update_on_integrate
branch
from
0bd3390 to
dfd0c03
Compare
Contributor
Author
|
Hello @rgonzalezfluendo, can you please review this? |
rgonzalezfluendo
approved these changes
Feb 18, 2025
cfoch
changed the title
cfoch
changed the title
cfoch
changed the title
rgonzalezfluendo
approved these changes
Feb 20, 2025
rgonzalezfluendo
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate means that a feature has landed upstream. We must use 'upstream' instead of 'source' as we need to fetch the latest, integrated, changes. If we do so, 'source' will be outdated, so we need to update it too.