-
Notifications
You must be signed in to change notification settings - Fork 402
New Generator: Apothecary Drawer Box #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
49b1019
to
4c102a3
Compare
This really should be 3 different PRs. Anyway let's have a look at the commits one by one. While I think adding the dimensions to the label is useful for some people I am not a fan of adding a new parameter to I am all for making the use of the Dockerfile for development purposes easier. This would just be merged if it was a separate PR. Now to the main course. We totally want something like this generator. Having an actual image would be appreciated, though. While not a requirement to be merged an option to just add rails similar to the |
@florianfesti thanks for the feedback! I will go ahead and break this out into multiple changes so we can work on each independently and rebase as needed. Would you prefer to have this PR get closed and I'll open a new one once all dependent changes are merged? Or are you okay with me leaving this PR open and I'll reference the other PR's in a comment so they are linked? For the labels, I totally understand. I was hoping quick and dirty would do the trick, but in the end it's not a good look. I'll give your recommendation a shot. As for the alternating finger joints, I will definitely take a look into that. If I am unable to make that work without too much difficulty, would you be open to keeping the joint implementation in-line as-is and then creating an issue for a future todo to refactor it and make it reusable? And I do have an image of a smaller test print I did so you can see how it looks. I was just going to wait until I printed the full size 3x4 setup before submitting the real image, but if you think this is good enough, I can go ahead and crop and add this one now. |
Relies on #794 for passing label_formats arg to sub-generators |
Adds a new label_format option that can be used to specify an option to allow for displaying measurements of a part instead of or in addition to the generators provided label. Made description the default option to preserve existing behavior.
New generator for Apothecary Drawer Box and optional drawers using existing generators. New custom edge added for alternating finger joints to save on material costs.
@florianfesti I tried out the platonic implementation but it didn't work for my use case since I don't want them to actually interlock, I want them to intentionally alternate skipping a joint. I ended up going with the I'm going to move this PR off of draft and it is ready for review! |
Adds a new generator for Apothecary style drawer box and optional drawers using existing generators