-
Notifications
You must be signed in to change notification settings - Fork 64
Propagate latest changes to autograd CM #2755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate latest changes to autograd CM #2755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 2 comments
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit otherwise looks good
Going to merge and test all runs from your branch |
bd88ce0
into
yaugenst-flex/autograd-web-cm
* Update to new data name * Remove polluting scope * no issue mixing import scope on run.py * Update tidy3d/plugins/smatrix/component_modelers/base.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * Readd PayType to run.py * Correct fix --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Greptile Summary
This PR propagates autograd component modeler (CM) changes across the Tidy3D repository by updating submodules, refactoring code organization, and integrating autograd web API support. The key changes include:
docs/notebooks
anddocs/faq
to synchronize documentation with the latest autograd CM functionality_run_component_modeler
and_compose_modeler_data_from_sim_map
) frombase.py
torun.py
to separate concerns and avoid circular importsComponentModeler
toModalComponentModelerData
to align with the new architecture that separates modeler configuration from data/results classescompose_simulation_data_index
tocompose_simulation_data_map
) and improves error messagesThe changes maintain backward compatibility while enabling component modelers to leverage the autograd web API execution path. This is part of a broader architectural shift to separate component modeler configuration from data handling, improving code organization and supporting advanced optimization workflows through autograd.
Important Files Changed
File Changes Summary
docs/notebooks
docs/faq
tidy3d/plugins/smatrix/component_modelers/base.py
tests/test_plugins/smatrix/test_component_modeler_autograd.py
tidy3d/plugins/smatrix/run.py
Confidence score: 4/5
Sequence Diagram