Fix getOptimalThreadCount segfault #714
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ached method is also not 100% necessary
DiamonDinoia
commented
Jul 24, 2025
| } | ||
| return physicalCoreCount; | ||
| #endif | ||
| // in ARM and RISKV we only need this |
There was a problem hiding this comment.
@ivansarno, Am I correct in assuming that RISK-V CPUs do not have Hyper-threading?
There was a problem hiding this comment.
Yes, no widely used RISC-V core has hyperthreading, except perhaps some experimental core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the method used in master is not compatible with very old kernels.
I replaced here with using
/sys/devices/system/cpu/presentwhich should be compatible with Linux kernels 2.6+.I also added a print to time how long it takes. Optimizing this avoiding heap allocations and std::set did not make a meaningful time difference so I left the easiest implementation.