fix(#51): stream emits error when stream triggers limit #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

lalawow wants to merge 1 commit into flash-oss:master from lalawow:master

lalawow commented Apr 24, 2025

In #51 , we found the stream triggers only a limit event when the file size exceeds the limit.

We want to emit an error event to make people can catch it on 'error'.


          fix(flash-oss#51): stream emits error when stream triggers limit

bf0f25d

Collaborator

koresar commented Apr 24, 2025

Looks good. Would require a unit test too, pretty please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet