Fix release github workflow #821
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadim Aleksandrov <[email protected]>
verdel
force-pushed
the
fix-release-github-workflow
branch
from
3077f7b to
f3ce17d
Compare
|
@ldmonster could I kindly request you to look into this? You appear to be the most active maintainer at the moment. We're considering shell-operator for production purposes but we need to be able to update the base images pushed from this repo 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In PR #761, the event that triggers the GitHub workflow for publishing the Docker image was changed. However, the
checkjob code was not updated accordingly. As a result, after the PR was merged, docker images stopped being published to the registry following the release of shell-operator.What this PR does / why we need it
I fixed the GitHub workflow so that when it is manually triggered from the main branch, the Docker image is published with the latest tag, and when a release is published, it is tagged with both the release tag and the latest tag.
This PR also fixes the issue #780.