One side put #303
Open
One side put #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new functions: regBuffer, put, putSignal, waitValue, and deregBuffer in the flagcxNetAdaptor structure for one-sided operations. - Updated flagcxIbSendComm structure to include putSignalScratchpad. - Enhanced ibrc_adaptor.cc with implementations for the new one-sided functions. - Updated ib_common.h to define a new request type for put operations. - Adjusted other adaptors to accommodate the new one-sided extensions.
- Added 'test_put.cpp' to implement a benchmark for one-sided communication. - Updated Makefile to include 'test-put' target for building the new test. - Enhanced clean target to remove 'test_put' binary.
|
|
MC952-arch
reviewed
Nov 17, 2025
| struct flagcxIbSendCommDev { | ||
| struct flagcxIbNetCommDevBase base; | ||
| struct ibv_mr *fifoMr; | ||
| struct ibv_mr *putSignalScratchpadMr; |
MC952-arch
reviewed
Nov 17, 2025
flagcx/adaptor/net/ibrc_adaptor.cc
Outdated
|
|
||
| // Structure to store handle info for allgather | ||
| struct flagcxIbGlobalHandleInfo { | ||
| uintptr_t *base_vas; |
MC952-arch
reviewed
Nov 17, 2025
| flagcxResult_t (*put)(void *sendComm, uint64_t srcOff, uint64_t dstOff, | ||
| size_t size, int srcRank, int dstRank, void **gHandles, | ||
| void **request); | ||
| flagcxResult_t (*putSignal)(void *sendComm, uint64_t dstOff, int tag, |
MC952-arch
reviewed
Nov 17, 2025
| @@ -0,0 +1,347 @@ | |||
| #include "flagcx.h" | |||
Collaborator
There was a problem hiding this comment.
Do we need to define regMr and deregMr in netAdaptor? How about we reuse flagcxCommRegister/Deregister and define a new funtion to retrieve global handles? Check flagcx/core/reg_pool.h/cc
- Moved the implementation of buffer registration and deregistration logic from flagcxIbRegBuffer and flagcxIbDeregBuffer - Updated the test_put benchmark to utilize the new structure for handling memory regions and keys. - Adjusted the net adaptor structure to remove unused function pointers for one-sided operations in various adaptors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.