Skip to content

Fixing MODES.ANALOG case in pinMode function #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing MODES.ANALOG case in pinMode function #274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions packages/firmata-io/lib/firmata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,23 +934,14 @@ class Firmata extends Emitter {

pinMode(pin, mode) {
if (mode === this.MODES.ANALOG) {
// Because pinMode may be called before analogRead(pin, () => {}), but isn't
// necessary to initiate an analog read on an analog pin, we'll assign the
// mode here, but do nothing further. In analogRead(), the call to
// reportAnalogPin(pin, 1) is all that's needed to turn on analog input
// reading.
//
// reportAnalogPin(...) will reconcile the pin number as well, the
// same operation we use here to assign a "mode":
this.pins[this.analogPins[pin]].mode = mode;
} else {
pin = this.analogPins[pin];
}
this.pins[pin].mode = mode;
writeToTransport(this, [
PIN_MODE,
pin,
mode
]);
}
}

/**
Expand Down