Include ROL in optimisation tests #4581
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
reviewed
Sep 22, 2025
| "pdf2image", | ||
| "pygraphviz", | ||
| "pylit", | ||
| "pyroltrilinos", |
There was a problem hiding this comment.
It might be good to enable pip install firedrake[pyrol] by adding another dependency group. If so we also add a little bit of info here.
angus-g
force-pushed
the
angus-g/pyrol-test
branch
2 times, most recently
from
6cd37eb to
f1774dc
Compare
angus-g
force-pushed
the
angus-g/pyrol-test
branch
2 times, most recently
from
e2ec8d2 to
11b2cd8
Compare
|
These changes should maybe go into |
angus-g
force-pushed
the
angus-g/pyrol-test
branch
from
11b2cd8 to
c61add4
Compare
|
Sure, I'm happy to change the base for this. That'd make life slightly easier for our transition to |
Requires pyroltrilinos in the ci dependency set
angus-g
force-pushed
the
angus-g/pyrol-test
branch
from
c61add4 to
b9ba63b
Compare
Needed until the ROL changes land in pyadjoint 2025.10.1 (presumably)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Install ROL through
pyroltrilinosinto thecidependency set, and add to some of the parameterised optimisation tests. Requires dolfin-adjoint/pyadjoint#223.In the default configurations, TAO's NLS does very well compared to a default Lin-More trust region in ROL. Very likely these tests should use a line search in ROL, I just need to figure out what the parameters are actually called... Even though the tests (seem to) pass, the optimisation doesn't actually converge to the specified tolerance!