Skip to content

Conversation

leo-collins
Copy link
Contributor

connorjward
connorjward previously approved these changes Aug 1, 2025
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try pushing a couple of empty commits to this branch (git commit --allow-empty -m "Empty commit") so we can check that it doesn't happen over a couple of CI runs. Obviously give CI time to complete in between.

@connorjward
Copy link
Contributor

Was this closed due to #4484? This would still be very helpful to merge into release as we are still seeing test failures there.

@leo-collins
Copy link
Contributor Author

It didn't seem to fix the test failure. I'll try it again with an even lower tolerance

@leo-collins leo-collins reopened this Aug 21, 2025
@connorjward
Copy link
Contributor

If it doesn't work then I don't mind having stochastic failures in this one test until we merge main. Not worth spending too much time on.

I guess we could alternatively skip this test in release knowing that it is fixed in main.

@connorjward
Copy link
Contributor

Let's close this. Merging main into release is going to happen soon.

@connorjward connorjward closed this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants