Mesh: extend P1 cell_sizes to high-order meshes #4218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/cell-sizes
branch
from
d6f5e36 to
2f7a203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some physically-mapped elements (Argyris, HCT) have vertex DOFs scaled by the local cell diameter to prevent poor conditioning, and we store this as
Mesh.cell_sizes(an attribute that should arguably become private). We obtain the scaling factor at vertices by projecting theCellDiameterinto P1.However
CellDiameteris not implemented on high order meshes (it should be very difficult to compute), but in principle we just need any O(h) scaling. This PR circumvents the issue by always computing the CellDiameter on an affine mesh obtained from the vertices of the high-order mesh.