Skip to content

fix: refuse to process unsupported feature #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: agave-v3.0.0
Choose a base branch
from
Draft

fix: refuse to process unsupported feature #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ca398
fix: refuse to process unsupported feature
0xalpharush Sep 8, 2025
c07e1f8
cat log on failure
0xalpharush Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions scripts/run_test_vectors.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,23 @@ else
cd ../..
fi

find dump/test-vectors/instr/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_instr > $LOG_PATH/test_exec_instr.log 2>&1
find dump/test-vectors/txn/fixtures/precompile -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_txn > $LOG_PATH/test_exec_precompile.log 2>&1
find dump/test-vectors/txn/fixtures/programs -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_txn > $LOG_PATH/test_exec_txn.log 2>&1
find dump/test-vectors/block/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_block > $LOG_PATH/test_exec_block.log 2>&1
find dump/test-vectors/syscall/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_vm_syscall > $LOG_PATH/test_exec_vm_syscall.log 2>&1
find dump/test-vectors/vm_interp/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_vm_interp > $LOG_PATH/test_exec_vm_interp.log 2>&1
find dump/test-vectors/elf_loader/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_elf_loader > $LOG_PATH/test_exec_elf_loader.log 2>&1
run_test() {
local log_file="$1"
local cmd="$2"

if ! eval "$cmd > $log_file 2>&1"; then
cat "$log_file"
exit 1
fi
}

run_test "$LOG_PATH/test_exec_instr.log" "find dump/test-vectors/instr/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_instr"
run_test "$LOG_PATH/test_exec_precompile.log" "find dump/test-vectors/txn/fixtures/precompile -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_txn"
run_test "$LOG_PATH/test_exec_txn.log" "find dump/test-vectors/txn/fixtures/programs -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_txn"
run_test "$LOG_PATH/test_exec_block.log" "find dump/test-vectors/block/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_block"
run_test "$LOG_PATH/test_exec_vm_syscall.log" "find dump/test-vectors/syscall/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_vm_syscall"
run_test "$LOG_PATH/test_exec_vm_interp.log" "find dump/test-vectors/vm_interp/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_vm_interp"
run_test "$LOG_PATH/test_exec_elf_loader.log" "find dump/test-vectors/elf_loader/fixtures -type f -name '*.fix' | xargs -P $NUM_PROCESSES -n 1000 ./target/release/test_exec_elf_loader"

failed=`grep -wR FAIL $LOG_PATH | wc -l`
passed=`grep -wR OK $LOG_PATH | wc -l`
Expand Down
15 changes: 15 additions & 0 deletions src/utils/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ impl From<&proto::FeatureSet> for FeatureSet {
let mut feature_set = FeatureSet::default();
for id in &input.features {
if let Some(pubkey) = INDEXED_FEATURES.get(id) {
if !crate::SUPPORTED_FEATURES.contains(id)
&& !crate::HARDCODED_FEATURES.contains(id)
{
panic!("Feature: ({}, {}) is not supported: ", pubkey, id);
}
feature_set.activate(pubkey, 0);
}
}
Expand Down Expand Up @@ -78,3 +83,13 @@ pub const fn pchash_inverse(hash: u32) -> u32 {
x = x.wrapping_mul(0xdee13bb1);
x
}

#[test]
#[should_panic(expected = "is not supported")]
fn test_reject_unsupported_feature() {
let unsupported_feature = feature_u64(&agave_feature_set::reenable_sbpf_v0_execution::id());
let proto_features = proto::FeatureSet {
features: vec![unsupported_feature],
};
let _ = FeatureSet::from(&proto_features);
}
Loading