Skip to content

ignore: test whether fixtures pass when strictly enforcing feature set #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ignore: test whether fixtures pass when strictly enforcing feature set #6312

wants to merge 1 commit into from

Conversation

0xalpharush
Copy link

No description provided.

@0xalpharush 0xalpharush force-pushed the test/solana-conformance-fixtures branch from 147b4c7 to 6b226bb Compare September 10, 2025 20:06
@0xalpharush 0xalpharush force-pushed the test/solana-conformance-fixtures branch from 6b226bb to 8b23b67 Compare September 10, 2025 20:07
@0xalpharush 0xalpharush marked this pull request as ready for review September 10, 2025 20:11
@0xalpharush 0xalpharush changed the title test whether fixtures pass when strictly enforcing feature set ignore: test whether fixtures pass when strictly enforcing feature set Sep 10, 2025
mjain-jump
mjain-jump requested changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@mjain-jump mjain-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default in FD, any features inside feature_map.json are supported, and any features explicitly marked as cleaned_up / hardcode_for_fuzzing are hardcoded.

@0xalpharush
Copy link
Author

I was attempting to compare to this. It would be a bit strange if the fixtures are passing for features that are not yet implemented, but it's possible the comments are out of date.

The failure before it exited early is due to a cleaned up feature, so it didn't reach the intrs fixtures

firedancer/src/flamenco/features/feature_map.json

Line 105 in 3e270a5

{"name":"cap_accounts_data_size_per_block","pubkey": "qywiJyZmqTKspFg2LeuUHqcA5nNvBgobqb9UprywS9N","cleaned_up":[1,18,0],"reverted":1},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjain-jump mjain-jump mjain-jump requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xalpharush @mjain-jump