-
Notifications
You must be signed in to change notification settings - Fork 280
gui: compress ws messages #5337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jherrera-jump
wants to merge
1
commit into
main
Choose a base branch
from
jherrera/websocket-compression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10a88e7
to
6e12737
Compare
94460a1
to
3446eea
Compare
Without compression (.venv) [jherrera@tsnj2-ossdev-firedancer39 gui]$ python3 bandwidth.py
Incoming bandwidth for ('peers', 'update') : 50.68 Mbps
Incoming bandwidth for ('epoch', 'new') : 8.87 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers') : 0.15 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall') : 0.05 Mbps
Incoming bandwidth for ('summary', 'tps_history') : 0.03 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric') : 0.02 Mbps
Incoming bandwidth for ('slot', 'update') : 0.02 Mbps
Incoming bandwidth for ('summary', 'startup_progress') : 0.01 Mbps
Incoming bandwidth for ('summary', 'tiles') : 0.01 Mbps
Incoming bandwidth for ('summary', 'estimated_tps') : 0.00 Mbps
Incoming bandwidth for ('summary', 'estimated_slot_duration_nanos') : 0.00 Mbps
Incoming bandwidth for ('summary', 'optimistically_confirmed_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'completed_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'root_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'skip_rate') : 0.00 Mbps
Total incoming bandwidth: 59.85 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers') : 0.14 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall') : 0.06 Mbps
Incoming bandwidth for ('slot', 'update') : 0.02 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric') : 0.02 Mbps
Incoming bandwidth for ('summary', 'estimated_tps') : 0.00 Mbps
Incoming bandwidth for ('summary', 'optimistically_confirmed_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'estimated_slot_duration_nanos') : 0.00 Mbps
Total incoming bandwidth: 0.24 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers') : 0.14 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall') : 0.05 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric') : 0.02 Mbps
Incoming bandwidth for ('slot', 'update') : 0.02 Mbps
Incoming bandwidth for ('summary', 'estimated_tps') : 0.00 Mbps
Incoming bandwidth for ('summary', 'estimated_slot_duration_nanos') : 0.00 Mbps
Incoming bandwidth for ('summary', 'optimistically_confirmed_slot') : 0.00 Mbps
Total incoming bandwidth: 0.24 Mbps With compression (.venv) [jherrera@tsnj2-ossdev-firedancer39 fd1]$ python3 src/disco/gui/bandwidth.py
Incoming bandwidth for ('peers', 'update') : 11.87 Mbps
Incoming bandwidth for ('epoch', 'new') : 4.48 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers') : 0.15 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall') : 0.03 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric') : 0.01 Mbps
Incoming bandwidth for ('slot', 'update') : 0.01 Mbps
Incoming bandwidth for ('summary', 'tps_history') : 0.01 Mbps
Incoming bandwidth for ('summary', 'estimated_tps') : 0.00 Mbps
Incoming bandwidth for ('summary', 'startup_progress') : 0.00 Mbps
Incoming bandwidth for ('summary', 'estimated_slot_duration_nanos') : 0.00 Mbps
Incoming bandwidth for ('summary', 'optimistically_confirmed_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'tiles') : 0.00 Mbps
Incoming bandwidth for ('summary', 'completed_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'root_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'skip_rate') : 0.00 Mbps
Total incoming bandwidth: 16.58 Mbps
Incoming bandwidth for ('summary', 'live_tile_timers') : 0.14 Mbps
Incoming bandwidth for ('summary', 'live_txn_waterfall') : 0.03 Mbps
Incoming bandwidth for ('summary', 'live_tile_primary_metric') : 0.01 Mbps
Incoming bandwidth for ('slot', 'update') : 0.01 Mbps
Incoming bandwidth for ('summary', 'estimated_tps') : 0.00 Mbps
Incoming bandwidth for ('summary', 'optimistically_confirmed_slot') : 0.00 Mbps
Incoming bandwidth for ('summary', 'estimated_slot_duration_nanos') : 0.00 Mbps
Total incoming bandwidth: 0.20 Mbps Note that since small messages are not compressed, the bandwidth after startup is barely changed. |
58613db
to
18eaf56
Compare
18eaf56
to
a2bfb2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows clients to optionally compress websocket messages larger than 200 bytes (arbitrary threshold).
see firedancer-io/firedancer-frontend#33