Fix CMake issues with Program Files (x86) escaping + recursively called message func #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade VS - support 2015
Add support for Visual Studio 2017
Allow Jenkins Build via SUPPRESS_MESSAGES
|
Hi @DerekZiemba ; did you mean to close this? I don't see an immediate problem with merging it... |
|
O wow this is a pleasant surprise, I thought this was abandoned! I meant to merge into our fork, but this works just as well. In this case there is some other things I may want to merge. I try to typically keep the fork as close to original as possible, so modifications are done externally where possible. |
|
No, not abandoned; just not frequently used anymore, with plugins no longer working on most browsers =] Reopen the PR and I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.