FIREBREATH-231 Keyevent Text Support #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why, but the diff isn't comparing properly; most likely you changed the line endings accidnetally with the commit or perhaps changed the 4 spaces to tabs. It'll take me longer to get to this because of that; it's harder to review the commit and I'll need to pull it in manually to fix the issues so the code is uniform. :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for text in key events, and an implementation for it on Windows. I don't have any other platforms available right now, but I'll look into Linux very soon.
JIRA Issue: http://jira.firebreath.org/browse/FIREBREATH-231