Skip to content

Conversation

hjkmarshall
Copy link

Description

Add Embeddable integration guide for connecting to Firebolt
Includes prerequisites, setup steps, API example, and links to further resources.

When should this PR be released to the public?

Immediate release.

Checklist below completed.

Documentation Checklist

  • I've previewed my documentation locally running make start-local (or using this tutorial)
  • I've validated that indexing works and that I'm able to navigate to the documentation page from the table of contents
  • If I added SQL examples, I have validated that they run correctly and as described.

If this PR touches a function implementation (aggregate, scalar, or table-valued):

  • I've made sure my documentation is aligned with these guidelines on function documentation
  • I've validated that the parent of my docs page is set correctly and the function shows up in the right category of the table of contents
  • I've made sure that the function was added to the function glossary

@hjkmarshall hjkmarshall requested a review from nanimal-fb as a code owner April 30, 2025 17:57
```javascript
const apiKey = '<your API Key>';
const connectionName = '<some unique name>';
const BASE_URL = 'https://api.<your-region>.embeddable.com';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use the same naming style for variables


```javascript
const apiKey = '<your API Key>';
const connectionName = '<some unique name>';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we define connection name here, but don't use it elsewhere. We can potentially use it in body.name field

Copy link
Contributor

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants