Update benchmark to work with Databricks #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code to execute benchmarks on Databricks SQL, and Databricks SQL compatible FireScale queries.
fb-cole
requested changes
Jul 10, 2025
Comment on lines
+86
to
+96
| VACUUM uservisits; | ||
|
|
||
| VACUUM uservisits; | ||
|
|
||
| VACUUM rankings; | ||
|
|
||
| VACUUM searchwords; | ||
|
|
||
| VACUUM agents; | ||
|
|
||
| VACUUM ipaddresses; |
There was a problem hiding this comment.
Do you VACUUM in Databricks / have you validated that this setup file works for Databricks?
| @@ -0,0 +1,52 @@ | |||
| { | |||
| "query 1": | |||
There was a problem hiding this comment.
This file isn't right. It should be the queries we selected for concurrent testing with K6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to execute benchmarks on Databricks SQL, and Databricks SQL compatible FireScale queries.