Skip to content

fix(go/ai): skip JSON validation for non-text parts #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2025
Merged

fix(go/ai): skip JSON validation for non-text parts #3634

merged 5 commits into from
Sep 29, 2025
+141 −18

Conversation

hugoaguirre
Copy link
Contributor

Checklist (if applicable):

@hugoaguirre hugoaguirre linked an issue Sep 24, 2025 that may be closed by this pull request
[Go] Prompts with "WithTools" and "WithOutputType" results in error #3626
Closed
@hugoaguirre hugoaguirre marked this pull request as ready for review September 25, 2025 16:52
@apascal07 apascal07 self-requested a review September 25, 2025 17:07
janishorsts
janishorsts reviewed Sep 25, 2025
View reviewed changes
@apascal07 apascal07 merged commit ee15f73 into main Sep 29, 2025
6 checks passed
@apascal07 apascal07 deleted the haguirre/formatter-fixes branch September 29, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apascal07 apascal07 apascal07 approved these changes

+1 more reviewer

@janishorsts janishorsts janishorsts left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
fix go
Projects
Genkit Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Go] Prompts with "WithTools" and "WithOutputType" results in error
3 participants
@hugoaguirre @janishorsts @apascal07