-
Notifications
You must be signed in to change notification settings - Fork 16
feat: backlinks from booking page #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
| booking: | ||
| - "cd-website" | ||
| - "db-website-fip-db" | ||
| - "db-website-fip-international" | ||
| - "cd-ticket-office" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if tracking the booking platforms in another place is a good idea. I'm sure that the list will get out-of-sync at some point. Instead, we could automatically derive the ticket offices by iterating over the operators and check if the raw content contains booking id="%s". It's less performant during build time, but given the limited number of operators it shouldn't be an issue. What do you think about the idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be an alternative. I wonder if the booking options change that often so the list will get out-of-sync.
I’ve discussed the new index with @lenderom, so I’m interested to hear his opinion too :)
If we agree, the mapping mechanic could be changed.
|
@therobrob Thanks for implementing this ❤️ |
Because the index is on the operator pages, we need an different logic for related-partial than before.