Skip to content

Conversation

@therobrob
Copy link
Member

@therobrob therobrob commented Nov 16, 2025

  • added index "booking" to all operator pages
  • modified related-partial
  • added backlinks from booking page to operator page

Because the index is on the operator pages, we need an different logic for related-partial than before.

@therobrob therobrob linked an issue Nov 16, 2025 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Nov 16, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 8500d86
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/6919d816e1d5660008d6895d
😎 Deploy Preview https://deploy-preview-468--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Nov 16, 2025

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

Comment on lines +8 to +12
booking:
- "cd-website"
- "db-website-fip-db"
- "db-website-fip-international"
- "cd-ticket-office"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if tracking the booking platforms in another place is a good idea. I'm sure that the list will get out-of-sync at some point. Instead, we could automatically derive the ticket offices by iterating over the operators and check if the raw content contains booking id="%s". It's less performant during build time, but given the limited number of operators it shouldn't be an issue. What do you think about the idea?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an alternative. I wonder if the booking options change that often so the list will get out-of-sync.
I’ve discussed the new index with @lenderom, so I’m interested to hear his opinion too :)
If we agree, the mapping mechanic could be changed.

@lenderom
Copy link
Member

@therobrob Thanks for implementing this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backlink from booking page

4 participants