[DO NOT MERGE] fix: safer two workflow filecoin upload #822
Conversation
|
FYI I had to kick off the upload workflow manually since it will only run automatically when merged to main.. so i got the build artifact, 
Workflow: https://github.com/filecoin-project/lotus-docs/actions/runs/18170047009 still debugging some things.. will update this comment when I get it working. edit: successful build flow: https://github.com/filecoin-project/lotus-docs/actions/runs/18170176166 |
|
Filecoin Pin Upload ✅
|
SgtPooki
changed the title
| if: ${{ github.event.workflow_run.conclusion == 'success' || github.event_name == 'workflow_dispatch' }} | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.FILECOIN_PIN_GH_TOKEN }} |
There was a problem hiding this comment.
| GITHUB_TOKEN: ${{ secrets.FILECOIN_PIN_GH_TOKEN }} | |
| GITHUB_TOKEN: ${{ github.token }} |
Why do we need a special secret for this?
| path: public | ||
| minDays: 30 | ||
| maxTopUp: ${{ github.event_name == 'pull_request' && '0.0001' || '0.01' }} | ||
| mode: upload |
There was a problem hiding this comment.
I assume we'll also show how we can store previews with a different dataset.
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build site | ||
| run: npm run build |
There was a problem hiding this comment.
I was surprised that there wasn't existing CI to hook into, but I guess that is abstracted away by a fleek app or something else
| uses: sgtpooki/filecoin-upload-action@641a2bf866d4ad0c47c98c0ddefaffdd4e628500 | ||
| with: | ||
| path: public |
There was a problem hiding this comment.
Do we also want to be explicit about the mode?
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20.x |
There was a problem hiding this comment.
| node-version: 20.x | |
| node-version: 'lts/*' |
3 participants
replacement for #821..
follows much safer two workflow pattern