Improve the MillerLoopResult type.
#64
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues with
MillerLoopResult.It makes it more usable. Currently, the type cannot be converted into a
Gtelement withfinal_exponentiation, which makes the type quite useless otherwise.It makes it coherent. The type documentation states that it can't be compared. However, the type still implements
PartialEqandEqwhich is contradictory. Moreover, the implementation ofEqandPartialEqwas wrong. It is known that twoMillerLoopResultsare not numerically equivalent. This fixes the type by adding afinal_verifymethod, and implementingEqandParitalEqbased on it.Allows for trivial construction. A
MillerLoopResultcan now be constructed using the top levelmiller_loopfunction.