Skip to content

fix dependency larastan #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix dependency larastan #71

wants to merge 1 commit into from

Conversation

gpibarra
Copy link

No description provided.

aspirantzhang
aspirantzhang reviewed May 16, 2025
View reviewed changes
Copy link

@aspirantzhang aspirantzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I recommend merging this PR.

@Abdulmajeed-Jamaan
Copy link
Contributor

I suggest removing other phpstan dependencies and keep the larastan only since they are already installed and managed within larastan composer file.

Also add the following line to the file phpstan.neon.dist under include so it loads laravel based phpstan rules:
- vendor/larastan/larastan/extension.neon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aspirantzhang aspirantzhang aspirantzhang left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpibarra @Abdulmajeed-Jamaan @aspirantzhang