Skip to content

Refactor MacroArgumentValue, reorganize files, and add unit tests #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

graycampbell
Copy link
Collaborator

📝 Summary

  • Refactored MacroArgumentValue to make the initializer throw an error instead of returning nil.
  • Updated MockCompilationCondition and MockSendableConformance to work with changes to MacroArgumentValue.
  • Added new unit tests and updated existing unit tests.

🛠️ Type of Change

  • Bug fix (change that fixes an issue)
  • New feature (change that adds functionality)
  • Breaking change (bug fix or feature that is not backwards compatible)
  • Documentation (DocC, API docs, markdown files, templates, etc.)
  • Testing (new tests, updated tests, etc.)
  • Refactoring or code formatting (no logic changes)
  • Updating dependencies (Swift packages, Homebrew, etc.)
  • CI/CD (change to automated workflows)

🧪 How Has This Been Tested?

  • New unit tests.
  • Existing unit tests still pass.

✅ Checklist

  • I have added relevant tests
  • I have verified all tests pass
  • I have formatted my code using SwiftFormat
  • I have updated documentation (if needed)
  • I have added the appropriate label to my PR
  • I have read the contributing guidelines
  • I agree to follow this project's Code of Conduct

@graycampbell graycampbell requested review from nolinmcfarland and a team June 11, 2025 17:11
@graycampbell graycampbell self-assigned this Jun 11, 2025
@graycampbell graycampbell requested review from bdrelling, pjtnt11 and pwufetch and removed request for a team June 11, 2025 17:11
@graycampbell graycampbell added refactoring Code refactoring changes testing Changes related to testing labels Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.24%. Comparing base (ed08a0c) to head (a900cc4).

Files with missing lines Patch % Lines
...ompilationCondition/MockCompilationCondition.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   68.87%   69.24%   +0.37%     
==========================================
  Files          71       73       +2     
  Lines        4572     4585      +13     
==========================================
+ Hits         3149     3175      +26     
+ Misses       1423     1410      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring changes testing Changes related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants