Add --skip-check option to omit test dependencies and %check section. #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not very fond of this change. It promotes bad habits. If we cannot run |
|
So that I'm clear, you're suggesting that --skip-check should add a bcond, right? Or do you mean that we shouldn't add the --skip-check option at all? Assuming the former, should the bcond default to not running the checks? That is, do we assume that the checks are being skipped because they won't work in mock by default (because they need network access, for example?) |
|
Either not adding this at all, or it should add a bcond, disabled by default. |
evgeni
pushed a commit
to evgeni/pyp2rpm
that referenced
this pull request
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the --skip-check option proposed in issue #162