Add inbox command using Optique #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 7, 2025 10:54
issues-auto-labeler
bot
added
component/cli
dahlia
requested changes
Sep 7, 2025
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
|
The docs for this pull request have been published: |
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
dahlia
requested changes
Sep 7, 2025
packages/cli/src/inbox.tsx
Outdated
| } from "@fedify/fedify"; | ||
| import { getLogger } from "@logtape/logtape"; | ||
| import * as colors from "@std/fmt/colors"; | ||
| import { parse } from "@std/semver"; |
There was a problem hiding this comment.
We probably don't need @std/semver here; you can use parseSemVer() from @fedify/fedify/nodeinfo IIRC.
|
The latest push to this pull request has been published to JSR and npm as a pre-release:
|
dahlia
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add inbox command with Optique
Related Issue
inboxcommand using Optique #396Changes
Benefits
Interfaces for the command option and option validations are removed.
Checklist
deno taskt test-allon your machine?Additional Notes
Removed redundant inbox.test.ts. The tests within were for option combinations that the Optique parser now handles.