Build librdkafka WITH_CURL if curl-static feature is selected #805
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before librdkafka was only built WITH_CURL if the feature curl was enabled. However, rdkafka also supports curl-static which statically links libcurl. In this case, librdkafka should also enable the WITH_CURL feature which is a prerequisite for enabling OIDC oauthbearer.
With librdkafka 2.12.1 we can control via https.ca.location where curl picks up the ca-certificate when obtaining the OIDC token, for example.
|
You probably also need the changes in I also noticed this curl problem there and I think it might be causing the CI failures. |
Author
Awesome. Are you gonna incorporate the curl-static changes in #803 @thalesfragoso? If yes, then #803 should supersede this PR. Feel free to close this PR if this is the case and I'll wait until #803 is merged. |
|
@tillrohrmann I'm neither the author of the PR nor a maintainer, but the curl changes seem to be in the other PR already and CI is running, hopefully it will get it merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before librdkafka was only built WITH_CURL if the feature curl was enabled. However,
rdkafka also supports curl-static which statically links libcurl. In this case, librdkafka
should also enable the WITH_CURL feature which is a prerequisite for enabling OIDC oauthbearer.
Additionally, this PR bumps librdkafka to 2.12.1 which allows us to configure the ca certificate location for the statically linked curl library via
https.ca.location(see also #800 (comment)).