-
Notifications
You must be signed in to change notification settings - Fork 207
Bundle dlls for windows app #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 Walkthrough""" WalkthroughThe Tauri desktop application's configuration file was updated to add a "bundle" section that specifies four Microsoft Visual C++ runtime DLL files as resources to be included when bundling the application. No other configuration or code changes were made. Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to configuration and resource bundling. Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
apps/desktop/src-tauri/dlls/msvcp140.dll
is excluded by!**/*.dll
apps/desktop/src-tauri/dlls/msvcp140_1.dll
is excluded by!**/*.dll
apps/desktop/src-tauri/dlls/vcruntime140.dll
is excluded by!**/*.dll
apps/desktop/src-tauri/dlls/vcruntime140_1.dll
is excluded by!**/*.dll
📒 Files selected for processing (1)
apps/desktop/src-tauri/tauri.conf.stable.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: ci (macos, macos-latest)
- GitHub Check: ci (windows, windows-latest)
resolves #66
Todo