SonicRetry combined PR[CMSSW_15_1_0_pre6] #24
+557
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r method in TritonClient. Update BuildFile.xml and fix formatting in header files.
…tructor for TritonClient, and update BuildFile.xml to include Catch2 for testing.
…tests; remove old cfg
…lection; remove unused parameters and improve documentation.
kpedro88
reviewed
Sep 15, 2025
| if (client_) { | ||
| client_->evaluate(); | ||
| } else { | ||
| edm::LogError("RetryActionBase") << "Client pointer is null, cannot evaluate."; |
There was a problem hiding this comment.
This should be an exception rather than a LogError. (It may actually need to be a return false or similar, because the call chain is client->finish() -> action->retry() -> action->eval(), and only finish() should actually emit an exception.)
There was a problem hiding this comment.
This comment has not been addressed yet
kpedro88
reviewed
Sep 17, 2025
| } catch (std::exception& e) { | ||
| edm::LogError("RetryActionDiffServer") << "Failed to retry with alternative server: " << e.what(); | ||
| } catch (...) { | ||
| edm::LogError("RetryActionDiffServe: rUnknownFailure") << "An unknown exception was thrown"; |
| @@ -0,0 +1,22 @@ | |||
| #!/bin/bash | |||
| if (client_) { | ||
| client_->evaluate(); | ||
| } else { | ||
| edm::LogError("RetryActionBase") << "Client pointer is null, cannot evaluate."; |
There was a problem hiding this comment.
This comment has not been addressed yet
| parser.add_argument("--device", default="auto", type=str.lower, choices=allowed_devices, help="specify device for fallback server") | ||
| parser.add_argument("--container", default="apptainer", type=str.lower, choices=allowed_containers, help="specify container for fallback server") | ||
| parser.add_argument("--tries", default=0, type=int, help="number of retries for failed request") | ||
| parser.add_argument("--retryAction", default="same", type=str, choices=["same","diff"], help="retry policy: same server or different server") |
There was a problem hiding this comment.
this should be added to getParser() in customize.py
Comment on lines
+24
to
+29
| parser.add_argument("--noShm", default=False, action="store_true", help="disable shared memory") | ||
| parser.add_argument("--compression", default="", type=str, choices=allowed_compression, help="enable I/O compression") | ||
| parser.add_argument("--ssl", default=False, action="store_true", help="enable SSL authentication for server communication") | ||
| parser.add_argument("--device", default="auto", type=str.lower, choices=allowed_devices, help="specify device for fallback server") | ||
| parser.add_argument("--container", default="apptainer", type=str.lower, choices=allowed_containers, help="specify container for fallback server") | ||
| parser.add_argument("--tries", default=0, type=int, help="number of retries for failed request") |
There was a problem hiding this comment.
these are redundant with customize.py and should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #23 to CMSSW_15_1_0_pre6.
PR description:
RetryActionDiffServerfor SonicTriton usingTritonService’s server registry; remove per-action alternate server parameters.TritonClient::updateServer(TritonService::Server::fallbackName)to switch servers on retry, per review guidance.HeterogeneousCore/SonicTriton/test/test_RetryActionDiffServer.cc(arms → updateServer(fallback) → no-op on second retry → exception path is caught).HeterogeneousCore/SonicTriton/test/tritonTest_cfg.pywith--retryAction {same,diff}and a verbose confirmation line.TestHeterogeneousCoreSonicTritonRetryActionDiff_Logto assert the selected retry policy.PR validation:
Built and ran unit/integration tests in
CMSSW_15_1_0_pre6area:scram b -j 8TODO/To verify:
scram b runtests TEST=HeterogeneousCore/SonicTriton(passes)Client.Retryis explicitly configured.