This repository was archived by the owner on Feb 23, 2023. It is now read-only.
now fancybox come with power of sass. #1129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded 'position' property for button helper
i found that it's missing the controls and ps params on the youtube iframe src url so in line 100 of fancybox media helper file i added it and now it's working fine. ps: 'docs', controls: 1
Fix "parent" option
Page has include <object> tag, run $(this).css('position') will be error.
It's helps to hide standard hint, similar: https://yadi.sk/i/aIDJVqtdix2F2
Update README.md
Gradient has outdated direction syntax.
Remove moot `version` property from bower.json
apply transform3d to wrapper
Youtube play button doesn't work on mobile devices
Added composer.json and component installer configuration
Update README.md
Update jquery.fancybox.js
Not in all cases current.content is set. Therefore it’s necessary to check for given content before accessing object members.
This Patch just adds gulp support to fancybox, so developers can create a minified, and single css and javascript version on demand.
Add Gulp support
Implemented check for iframe content
|
Good work, thanks. |
|
thank you |
|
@arpanpatel I made the same thing for V3 #1176 ... but no answer :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
42 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I create a sass version of fancy box with lot's of option that users can customize. I request you to review and give me suggestion.