-
Notifications
You must be signed in to change notification settings - Fork 2
Datacollection docs, longText defaults and fix oneEllipsis line-clamp-4 #2777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the documentation structure for the OneDataCollection component by refactoring content organization and fixing line-clamp functionality in the ellipsis component.
- Reorganizes documentation files by extracting content into dedicated files (pagination, sorting, loading, etc.)
- Refactors component imports from FeatureCard to FeatureGrid for better content presentation
- Updates OneEllipsis component to fix line-clamp CSS implementation and add full text display option
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 8 comments.
Show a summary per file
File | Description |
---|---|
packages/react/src/experimental/OneDataCollection/__stories__/visualizations.mdx |
Updates imports and structure to use FeatureGrid instead of individual FeatureCard components |
packages/react/src/experimental/OneDataCollection/__stories__/value-display.mdx |
Adds new documentation file for value display concepts |
packages/react/src/experimental/OneDataCollection/__stories__/total-items-summary/total-items-summary.stories.tsx |
Removes "internal" tag from component metadata |
packages/react/src/experimental/OneDataCollection/__stories__/sorting/sorting.mdx |
Adds new documentation file for sorting functionality |
packages/react/src/experimental/OneDataCollection/__stories__/selectable-bulk-actions.mdx |
Adds detailed explanation of bulk actions functionality |
packages/react/src/experimental/OneDataCollection/__stories__/pagination/pagination.mdx |
Adds new documentation file for pagination concepts |
packages/react/src/experimental/OneDataCollection/__stories__/mockData.tsx |
Updates mock data to demonstrate longText cell type with line clamping |
packages/react/src/experimental/OneDataCollection/__stories__/loading/loading.mdx |
Adds new documentation file for loading states |
packages/react/src/experimental/OneDataCollection/__stories__/index.stories.tsx |
Updates title and tags for better organization |
packages/react/src/experimental/OneDataCollection/__stories__/index.mdx |
Major restructuring with FeatureGrid and removal of duplicated content |
packages/react/src/experimental/OneDataCollection/__stories__/filters.mdx |
Adds comprehensive filtering documentation |
packages/react/src/experimental/OneDataCollection/__stories__/cell-types.mdx |
Removes content (moved to value-display.mdx) |
packages/react/src/experimental/OneDataCollection/__stories__/actions/actions.mdx |
Adds detailed action hierarchy documentation |
packages/react/src/components/value-display/types/longText.tsx |
Refactors to support full text display and improves line-clamp implementation |
packages/react/src/components/value-display/__stories__/ValueDisplay.stories.tsx |
Updates story title and adds full text display example |
packages/react/src/components/value-display/__stories__/ValueDisplay.mdx |
Updates documentation for new longText functionality |
packages/react/src/components/OneEllipsis/__stories__/OneEllipsis.stories.tsx |
Adds new props and improves story structure |
packages/react/src/components/OneEllipsis/OneEllipsis.tsx |
Major refactor to fix line-clamp CSS and add semantic HTML tag support |
packages/react/docs/components/FeatureGrid.tsx |
Adds new FeatureGrid component for organizing feature cards |
packages/react/docs/components/FeatureCard.tsx |
Exports FeatureCardProps interface |
.tool-versions |
Updates Node.js version format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/react/src/experimental/OneDataCollection/__stories__/value-display.mdx
Outdated
Show resolved
Hide resolved
packages/react/src/experimental/OneDataCollection/__stories__/value-display.mdx
Outdated
Show resolved
Hide resolved
packages/react/src/experimental/OneDataCollection/__stories__/visualizations.mdx
Outdated
Show resolved
Hide resolved
packages/react/src/experimental/OneDataCollection/__stories__/index.mdx
Outdated
Show resolved
Hide resolved
packages/react/src/experimental/OneDataCollection/__stories__/index.mdx
Outdated
Show resolved
Hide resolved
packages/react/src/experimental/OneDataCollection/__stories__/sorting/sorting.mdx
Show resolved
Hide resolved
packages/react/src/experimental/OneDataCollection/__stories__/pagination/pagination.mdx
Show resolved
Hide resolved
packages/react/src/experimental/OneDataCollection/__stories__/pagination/pagination.mdx
Show resolved
Hide resolved
…value-display.mdx Co-authored-by: Copilot <[email protected]>
…value-display.mdx Co-authored-by: Copilot <[email protected]>
…index.mdx Co-authored-by: Copilot <[email protected]>
…alco/f0 into docs/datacollection-improvements
size-limit report 📦
|
🔍 Visual review for your branch is published 🔍Here are the links to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Screenshots (if applicable)
[Link to Figma Design](Figma URL here)
Implementation details