Skip to content

Conversation

sergiocarracedo
Copy link
Collaborator

@sergiocarracedo sergiocarracedo commented Oct 7, 2025

Description

  • docs: create datacollection features index in the main story for better navigation
  • feat: longText now makes mandatory the tooltip and cuts the clamps the text in line 3, added full property to show all.
  • fix: fix line-clamp-4 was not working
  • docs: improve ellipsis storybook
  • feat: ellipsis render custom tag

Screenshots (if applicable)

[Link to Figma Design](Figma URL here)

Implementation details

@Copilot Copilot AI review requested due to automatic review settings October 7, 2025 20:36
@sergiocarracedo sergiocarracedo requested a review from a team as a code owner October 7, 2025 20:36
@sergiocarracedo sergiocarracedo changed the title Datacollection docs improvements Datacollection docs, longText defaults and fix oneEllipsis line-clamp-4 Oct 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the documentation structure for the OneDataCollection component by refactoring content organization and fixing line-clamp functionality in the ellipsis component.

  • Reorganizes documentation files by extracting content into dedicated files (pagination, sorting, loading, etc.)
  • Refactors component imports from FeatureCard to FeatureGrid for better content presentation
  • Updates OneEllipsis component to fix line-clamp CSS implementation and add full text display option

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
packages/react/src/experimental/OneDataCollection/__stories__/visualizations.mdx Updates imports and structure to use FeatureGrid instead of individual FeatureCard components
packages/react/src/experimental/OneDataCollection/__stories__/value-display.mdx Adds new documentation file for value display concepts
packages/react/src/experimental/OneDataCollection/__stories__/total-items-summary/total-items-summary.stories.tsx Removes "internal" tag from component metadata
packages/react/src/experimental/OneDataCollection/__stories__/sorting/sorting.mdx Adds new documentation file for sorting functionality
packages/react/src/experimental/OneDataCollection/__stories__/selectable-bulk-actions.mdx Adds detailed explanation of bulk actions functionality
packages/react/src/experimental/OneDataCollection/__stories__/pagination/pagination.mdx Adds new documentation file for pagination concepts
packages/react/src/experimental/OneDataCollection/__stories__/mockData.tsx Updates mock data to demonstrate longText cell type with line clamping
packages/react/src/experimental/OneDataCollection/__stories__/loading/loading.mdx Adds new documentation file for loading states
packages/react/src/experimental/OneDataCollection/__stories__/index.stories.tsx Updates title and tags for better organization
packages/react/src/experimental/OneDataCollection/__stories__/index.mdx Major restructuring with FeatureGrid and removal of duplicated content
packages/react/src/experimental/OneDataCollection/__stories__/filters.mdx Adds comprehensive filtering documentation
packages/react/src/experimental/OneDataCollection/__stories__/cell-types.mdx Removes content (moved to value-display.mdx)
packages/react/src/experimental/OneDataCollection/__stories__/actions/actions.mdx Adds detailed action hierarchy documentation
packages/react/src/components/value-display/types/longText.tsx Refactors to support full text display and improves line-clamp implementation
packages/react/src/components/value-display/__stories__/ValueDisplay.stories.tsx Updates story title and adds full text display example
packages/react/src/components/value-display/__stories__/ValueDisplay.mdx Updates documentation for new longText functionality
packages/react/src/components/OneEllipsis/__stories__/OneEllipsis.stories.tsx Adds new props and improves story structure
packages/react/src/components/OneEllipsis/OneEllipsis.tsx Major refactor to fix line-clamp CSS and add semantic HTML tag support
packages/react/docs/components/FeatureGrid.tsx Adds new FeatureGrid component for organizing feature cards
packages/react/docs/components/FeatureCard.tsx Exports FeatureCardProps interface
.tool-versions Updates Node.js version format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

size-limit report 📦

Path Size
JS: Stable 581.71 KB (-0.07% 🔽)
JS: Experimental 968.81 KB (+0.05% 🔺)
CSS 71.85 KB (-0.27% 🔽)

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🔍 Visual review for your branch is published 🔍

Here are the links to:

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Coverage Report for packages/react

Status Category Percentage Covered / Total
🔵 Lines 16.89% 16449 / 97350
🔵 Statements 16.89% 16449 / 97350
🔵 Functions 43.74% 821 / 1877
🔵 Branches 70.59% 2310 / 3272
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/docs/components/FeatureCard.tsx 0% 0% 0% 0% 1-42
packages/react/docs/components/FeatureGrid.tsx 0% 0% 0% 0% 1-15
packages/react/src/components/OneEllipsis/OneEllipsis.tsx 100% 84% 100% 100%
packages/react/src/components/OneEllipsis/__stories__/OneEllipsis.stories.tsx 0% 100% 100% 0% 2-175
packages/react/src/components/value-display/__stories__/ValueDisplay.stories.tsx 0% 100% 100% 0% 2-674
packages/react/src/components/value-display/types/longText.tsx 18.75% 100% 0% 18.75% 11-14, 17-24, 42-61
packages/react/src/experimental/OneDataCollection/__stories__/index.stories.tsx 0% 100% 100% 0% 3-2108
packages/react/src/experimental/OneDataCollection/__stories__/mockData.tsx 0% 100% 100% 0% 2-1502
packages/react/src/experimental/OneDataCollection/__stories__/total-items-summary/total-items-summary.stories.tsx 0% 100% 100% 0% 2-81
Generated in workflow #8457 for commit b71d2d0 by the Vitest Coverage Report Action

Copy link
Contributor

@eliseo-juan eliseo-juan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sergiocarracedo sergiocarracedo merged commit fa8657e into main Oct 10, 2025
20 checks passed
@sergiocarracedo sergiocarracedo deleted the docs/datacollection-improvements branch October 10, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants