Skip to content

Conversation

dani-moreno
Copy link
Collaborator

Description

Fixes an error with the Card component. The div that contains the metadata and content of the Card, when is empty, is still displayed, making it look like there's more space to the bottom.

Slack: https://factorialteam.slack.com/archives/C082ZNKS403/p1759849355961809

Screenshots

Before

image

After

Screenshot 2025-10-07 at 19 37 49

@dani-moreno dani-moreno marked this pull request as ready for review October 7, 2025 17:41
@dani-moreno dani-moreno requested a review from a team as a code owner October 7, 2025 17:41
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Coverage Report for packages/react

Status Category Percentage Covered / Total
🔵 Lines 16.87% 16422 / 97295
🔵 Statements 16.87% 16422 / 97295
🔵 Functions 43.76% 821 / 1876
🔵 Branches 70.56% 2304 / 3265
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/F0Card/CardInternal.tsx 99.45% 93.1% 100% 99.45% 156
Generated in workflow #8451 for commit 3eacfaf by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Oct 7, 2025

🔍 Visual review for your branch is published 🔍

Here are the links to:

Copy link
Contributor

github-actions bot commented Oct 7, 2025

size-limit report 📦

Path Size
JS: Stable 581.67 KB (-0.07% 🔽)
JS: Experimental 967.87 KB (-0.05% 🔽)
CSS 72.04 KB (0%)

Copy link
Contributor

@eliseo-juan eliseo-juan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dani-moreno dani-moreno merged commit 54dd3cb into main Oct 8, 2025
20 checks passed
@dani-moreno dani-moreno deleted the fix-empty-div-card branch October 8, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants