FCT 37288 improve dates range human readable strings #2751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
size-limit report 📦
|
nlopin
reviewed
Oct 2, 2025
| @@ -186,7 +186,7 @@ export const WithCompareTo: Story = { | |||
| } as DatePickerValue, | |||
| granularities: ["day", "week", "month"], | |||
| minDate: subDays(today, 30), // Can't select dates before 30 days ago | |||
| maxDate: today, // Can't select dates after today | |||
| //maxDate: today, // Can't select dates after today | |||
nlopin
approved these changes
Oct 2, 2025
sergiocarracedo
deleted the
FCT-37288-improve-dates-range-human-readable-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the toString format for the distinct granularities, specially for ranges, for example:
fix: Week granularity for single week
fix: reset selection to the from date on granularity change to avoid select multiple items when granulary passes from examploe from month to days
fix: select componet doesnt update the option when the value prop changes
Screenshots (if applicable)
Screen.Recording.2025-10-02.at.16.28.21.mov
Implementation details