Skip to content

Conversation

sergiocarracedo
Copy link
Collaborator

@sergiocarracedo sergiocarracedo commented Sep 8, 2025

Description

Stabilize the tags related components

Needs a pending PR in the monorepo before merge it

Screenshots (if applicable)

image

Link to Figma Design

Implementation details

  • Review all storybook's stories to ensure the props are well documented
  • Move baseTag to internal folder as in not exported
  • Add info icon and hint to baseTag,
  • Add snapshot stories
  • F0TagAlert:
    • Remove customIcon prop
  • F0TagBalance: (complete revamp)
    • semantic props to avoid arbitrary text in the tag
    • add info and hint
    • add nullText state
    • State color based in the percent sign (can be inverted negative percent is good)
    • numeric values, can be formated and l10n, select the decimals and units
  • F0TagCompany / F0TagPerson / F0TagTEam:
    • homogenize props to name and src
    • allow no src
    • remove onClick
  • F0TagDot
    • Hide customColor prop as we should remove it in the future
  • F0TagList
    • Open overflow on hover
    • overflow toolltip bg color
    • overflow hover pointer
    • Remove description as is not part of the design
    • Remove layout prop
  • F0TagRaw:
    • Remove noBorder prop
    • remove className prop
    • make text required to use it as aria label
    • add onlyIcon prop to hide the label

Copy link
Contributor

github-actions bot commented Sep 8, 2025

Coverage Report for packages/react

Status Category Percentage Covered / Total
🔵 Lines 20.13% 15609 / 77537
🔵 Statements 20.13% 15609 / 77537
🔵 Functions 42.07% 688 / 1635
🔵 Branches 69.49% 2139 / 3078
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/tags/exports.tsx 0% 0% 0% 0% 1-10
packages/react/src/components/tags/F0Tag/index.ts 0% 0% 0% 0% 1
packages/react/src/components/tags/F0TagAlert/F0TagAlert.tsx 34.88% 100% 100% 34.88% 17-47
packages/react/src/components/tags/F0TagAlert/types.ts 0% 0% 0% 0% 1
packages/react/src/components/tags/F0TagAlert/__storybook__/TagAlert.stories.tsx 0% 100% 100% 0% 3-76
packages/react/src/components/tags/F0TagBalance/F0TagBalance.tsx 20.79% 100% 0% 20.79% 15-29, 32-43, 53-113
packages/react/src/components/tags/F0TagBalance/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagBalance/types.ts 0% 0% 0% 0% 1
packages/react/src/components/tags/F0TagBalance/__storybook__/TagBalance.stories.tsx 0% 100% 100% 0% 3-210
packages/react/src/components/tags/F0TagCompany/F0TagCompany.tsx 35.29% 100% 100% 35.29% 7-18
packages/react/src/components/tags/F0TagCompany/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagCompany/types.ts 100% 100% 100% 100%
packages/react/src/components/tags/F0TagCompany/__storybook__/TagCompany.stories.tsx 0% 100% 100% 0% 3-44
packages/react/src/components/tags/F0TagDot/F0TagDot.tsx 27.58% 100% 100% 27.58% 9-34
packages/react/src/components/tags/F0TagDot/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagDot/types.ts 100% 100% 100% 100%
packages/react/src/components/tags/F0TagDot/__storybook__/TagDot.stories.tsx 0% 100% 100% 0% 3-63
packages/react/src/components/tags/F0TagList/F0TagList.tsx 15.62% 100% 0% 15.62% 7-38
packages/react/src/components/tags/F0TagList/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagList/types.ts 0% 100% 100% 0% 9-18
packages/react/src/components/tags/F0TagList/__storybook__/TagList.stories.tsx 0% 0% 0% 0% 1-74
packages/react/src/components/tags/F0TagList/__storybook__/mockData.ts 0% 0% 0% 0% 1-150
packages/react/src/components/tags/F0TagList/components/TagCounter.tsx 18.91% 100% 0% 18.91% 15-50
packages/react/src/components/tags/F0TagPerson/F0TagPerson.tsx 33.33% 100% 100% 33.33% 7-19
packages/react/src/components/tags/F0TagPerson/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagPerson/types.ts 100% 100% 100% 100%
packages/react/src/components/tags/F0TagPerson/__storybook__/TagPerson.stories.tsx 0% 100% 100% 0% 3-49
packages/react/src/components/tags/F0TagRaw/F0TagRaw.tsx 29.62% 100% 100% 29.62% 9-30
packages/react/src/components/tags/F0TagRaw/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagRaw/types.ts 100% 100% 100% 100%
packages/react/src/components/tags/F0TagRaw/__storybook__/TagRaw.stories.tsx 0% 0% 0% 0% 1-73
packages/react/src/components/tags/F0TagStatus/F0TagStatus.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagStatus/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagStatus/types.ts 0% 0% 0% 0% 1-7
packages/react/src/components/tags/F0TagStatus/__storybook__/TagStatus.stories.tsx 0% 100% 100% 0% 3-85
packages/react/src/components/tags/F0TagTeam/F0TagTeam.tsx 35.29% 100% 100% 35.29% 7-18
packages/react/src/components/tags/F0TagTeam/index.tsx 100% 100% 100% 100%
packages/react/src/components/tags/F0TagTeam/types.ts 100% 100% 100% 100%
packages/react/src/components/tags/F0TagTeam/__storybook__/TagTeam.stories.tsx 0% 100% 100% 0% 3-43
packages/react/src/components/tags/internal/BaseTag/index.tsx 87.5% 12.5% 100% 87.5% 75, 80-82, 85-87
packages/react/src/components/value-display/types/tagList.tsx 66.66% 100% 0% 66.66% 16
packages/react/src/experimental/Forms/EntitySelect/index.stories.tsx 0% 100% 100% 0% 3-712
packages/react/src/experimental/Forms/EntitySelect/ListTag/index.tsx 0% 0% 0% 0% 1-51
packages/react/src/experimental/Lists/OnePersonListItem/index.tsx 0% 0% 0% 0% 1-140
packages/react/src/experimental/RichText/NotesTextEditor/index.stories.tsx 0% 100% 100% 0% 2-277
packages/react/src/experimental/Widgets/Content/CalendarEvent/index.tsx 0% 0% 0% 0% 1-162
packages/react/src/lib/numberFormat.ts 10% 100% 0% 10% 2-10
Generated in workflow #8271 for commit b5bd953 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Sep 8, 2025

🔍 Visual review for your branch is published 🔍

Here are the links to:

Copy link
Contributor

github-actions bot commented Sep 30, 2025

size-limit report 📦

Path Size
JS: Stable 394.11 KB (+0.12% 🔺)
JS: Experimental 777.38 KB (-0.06% 🔽)
CSS 71.87 KB (-0.28% 🔽)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants