This repository was archived by the owner on Nov 22, 2022. It is now read-only.
Add conditional import in accelerator_lowering.py to avoid ImportError #1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26885302 |
jeffreyliu3230
pushed a commit
to jeffreyliu3230/pytext
that referenced
this pull request
Mar 8, 2021
facebookresearch#1633) Summary: Pull Request resolved: facebookresearch#1633 Alternative approach to facebookresearch#1631. Handling ImportError of accelerator in accelerator_lowering.py instead of new_task.py. accelerator function is both used as a declarator on class AcceleratorTransformerLayers and called directly in lower_modules_to_accelerator. In addition to adding the try block for importing accelerator, accelerator_lowering_supported is used in lower_modules_to_accelerator to avoid ImportError. Differential Revision: D26885302 fbshipit-source-id: 13f8c9c23fa56db573c1ea32c582fee91a001972
jeffreyliu3230
force-pushed
the
export-D26885302
branch
from
5d59a3a to
650f985
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26885302 |
facebookresearch#1633) Summary: Pull Request resolved: facebookresearch#1633 Alternative approach to facebookresearch#1631. Handling ImportError of accelerator in accelerator_lowering.py instead of new_task.py. accelerator function is both used as a declarator on class AcceleratorTransformerLayers and called directly in lower_modules_to_accelerator. In addition to adding the try block for importing accelerator, accelerator_lowering_supported is used in lower_modules_to_accelerator to avoid ImportError. Differential Revision: D26885302 fbshipit-source-id: 7540b0443678fd5ca0536aafd0a1c0402b044ec0
jeffreyliu3230
force-pushed
the
export-D26885302
branch
from
650f985 to
9d38dca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26885302 |
|
This pull request has been merged in 653a05e. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Alternative approach to #1631. Handling ImportError of accelerator in accelerator_lowering.py instead of new_task.py.
accelerator function is both used as a declarator on class AcceleratorTransformerLayers and called directly in lower_modules_to_accelerator. In addition to adding the try block for importing accelerator, accelerator_lowering_supported is used in lower_modules_to_accelerator to avoid ImportError.
Differential Revision: D26885302