Add support for using Ubuntu 24.04 in CI #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
kou
force-pushed
the
ci-ubuntu-24.04
branch
2 times, most recently
from
d3ce4ca to
7328db7
Compare
GitHub hosted runner has GCC 14 by default. It seems that we can't use GTest 1.13.0 bundled in Velox with libstdc++ in GCC 14. We can use GTest 1.13.0 with libstdc++ in GCC 13. So this removes GCC 14 and install GCC 13. We can remove this workaround after Velox updates bundled GTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub hosted runner has GCC 14 by default. It seems that we can't use GTest 1.13.0 bundled in Velox with libstdc++ in GCC 14.
We can use GTest 1.13.0 with libstdc++ in GCC 13. So this removes GCC 14 and install GCC 13.
We can remove this workaround after Velox updates bundled GTest.