Skip to content

Conversation

mszabo-wikia
Copy link
Contributor

Most Meta C++ projects now use C++20 language features, causing the OSS build to fail.

Update the default CMAKE_CXX_STANDARD accordingly.

@meta-cla meta-cla bot added the CLA Signed label Sep 24, 2025
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83150457. (Because this pull request was imported automatically, there will not be any future comments.)

Copy link
Contributor

@quark-zju quark-zju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@mszabo-wikia mszabo-wikia force-pushed the update-default-cxx-standard branch from 2229855 to a343b0a Compare October 15, 2025 10:41
@facebook-github-bot
Copy link
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

@meta-codesync
Copy link

meta-codesync bot commented Oct 15, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83150457. (Because this pull request was imported automatically, there will not be any future comments.)

@mszabo-wikia
Copy link
Contributor Author

Windows failure is unrelated and should be fixed by facebookexperimental/edencommon#29

Most Meta C++ projects now use C++20 language features,
causing the OSS build to fail.

Update the default CMAKE_CXX_STANDARD accordingly.
@mszabo-wikia mszabo-wikia force-pushed the update-default-cxx-standard branch from a343b0a to 8e3bb98 Compare October 22, 2025 11:44
@facebook-github-bot
Copy link
Contributor

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants