Skip to content

Conversation

duotive
Copy link

@duotive duotive commented Sep 15, 2025

Description

This fixes a warning that appears as deprecated from PHP 8.2..
Fixes #3558

Type of change

Please delete options that are not relevant

  • Fix (non-breaking change which fixes an issue)

Checklist

  • [] I have commented my code, particularly in hard-to-understand areas, if any.
  • [] I have confirmed that my changes do not introduce any new PHPCS warnings or errors.
  • [] I have checked plugin debug logs that my changes do not introduce any new PHP warnings or FATAL errors.
  • [] I followed general Pull Request best practices. Meta employees to follow this wiki.
  • [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes.
  • [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.
  • [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this wiki.

Changelog entry

One liner entry to be surfaced in changelog.txt

Test Plan

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

Screenshots

Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate

Before

After

Copy link

meta-cla bot commented Sep 15, 2025

Hi @duotive!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

meta-cla bot commented Sep 15, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated warning
1 participant