Added unit test that breaks deserialization. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added if (!IsTypeGeneric(type)) to that method and it fixed it. However, I'd expect the empty dictionary to be empty and not null. So it looks like there is still work todo :. |
|
I was wondering if anyone has taken a look into this? |
|
@niemyjski was on a vacation. will have a look at it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the fix is inside of this method: public static Type[] GetGenericTypeArguments(Type type). The SettingsDictionary inherits from dictionary but doesn't have any generic type arguments. The base type would need to be checked.