<ImageWithZoom>: Add new prop to zoom only on click #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a prop to
<ImageWithZoom>
component which allows images to only be zoomed in if they are clicked.What:
I have started trying to use this library for my website, however have found it annoying that I cannot toggle the zoom behaviour on hover.
Specifically, I would like to enable zooming in the
ImageWithZoom
component only when the mouse has clicked the image, not necessarily on hover. Initially I tried to do this using thecarouselContext
as described in the docs however found that the props needed for this behaviour are exposed only internally within the react class.Why:
This will allow the company I'm working with to use this library and customise exactly when we see the 'inner' image; that is, on click instead of on hover on desktop.
How:
I added a
clicked
state attribute to determine if the image is clicked, and aonlyZoomOnClick
prop to theImageWithZoom
component, which (when true):Todos
There are a couple of things I'm still working out:
Checklist: