-
Notifications
You must be signed in to change notification settings - Fork 148
[eas-json] Allow a string of 1-50 characters as a track name #3031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tion and defaults
Subscribed to pull request
Generated by CodeMention |
/changelog-entry [bug-fix] [Allow a string of 1-50 characters as a track name] |
@quinlanj I tried to follow the pr description to update the changelog, but it seems like it's not working. Can you help me? Thank you. |
/changelog-entry bug-fix Allow a string of 1-50 characters as a track name |
Thanks for the PR. This also requires some API schema changes on our part so we'll need to tackle those first. In the meanwhile since the actual change is quite small, you can unblock yourself by adding the change on your local project with patch-package (or yarn patch if you're using yarn, bun patch if you're using bun etc) |
# Why https://exponent-internal.slack.com/archives/C011ZMXQ6SZ/p1755530483378679 Related — expo/eas-cli#3031 # How Changed submission config schema to allow any string as `track`, not only `production`/`internal`/`beta`/`alpha`. # Test Plan Tested along with all the pull requests in the mix. <img width="372" height="90" alt="Zrzut ekranu 2025-09-9 o 17 03 38" src="https://github.com/user-attachments/assets/0b260ad2-2379-4597-aa1c-dae8bf86446d" /> <img width="243" height="72" alt="Zrzut ekranu 2025-09-9 o 16 59 37" src="https://github.com/user-attachments/assets/4eef353d-ac7e-4b16-9413-a304a574b685" /> <img width="449" height="110" alt="Zrzut ekranu 2025-09-9 o 17 00 40" src="https://github.com/user-attachments/assets/58a44b7a-16bb-46b4-8d98-f233c196406a" /> <img width="366" height="85" alt="Zrzut ekranu 2025-09-9 o 17 00 35" src="https://github.com/user-attachments/assets/71013cd6-5f5e-4e38-951c-008642fbee8c" />
Why
Previously, the Android submit track in eas.json only allowed a fixed set of values ("beta", "alpha", "internal", "production"). However, Google Play supports custom track names, and users may need to specify arbitrary track names for advanced workflows. This PR enables more flexible usage by allowing any string of 1-50 characters as a track name.
Track name follows the rule defined by Google textfield. See the image below.
How
packages/eas-json/src/submit/schema.ts
to allow any string of 1-50 characters for the Android submit track property.packages/eas-json/schema/eas.schema.json
to addminLength
andmaxLength
for the track property, ensuring IDE and documentation support matches runtime validation.packages/eas-json/src/__tests__/submitProfiles-test.ts
to cover:Test Plan
my-custom-track
) is accepted.internal
.If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.
