feature!: knowledge graph flexibility #2030
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opAbstractQuerySynthesizer - Users should be able to set the relationship property to use for identifying clusters and the node property used for identifying abstract concepts. - This will not change default behavior, but allows users to override.
…opSpecificQuerySynthesizer - Users should be able to set the relationship type to use for identifying clusters and the relationship property used for identifying overlapping concepts within the triple. - This will not change default behavior, but allows users to override.
dosubot
bot
added
the
size:L
|
Failing unit tests seem to be triggered by the typo correction; lmk if changes are needed or if I should revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementations of the synthesizers (in particular,
MultiHopAbstractQuerySynthesizerandMultiHopSpecificQuerySynthesizer) have hard-coded values for the node- and relationship- properties/types they look for when generating scenarios and samples. This works when using the default knowledge graph transforms, but may cause unexpected behavior (or force users to use the expected hardcoded values when they do not actually correspond to the reality of property lineage) when using customized the knowledge graph transformations.This PR allows flexibility in defining the node-property, relationship-property, and relationship-type expected by the *QuerySynthesizers, while retaining the current behavior as default
The bulk of this PR is nonbreaking, but there may be a breaking typo fix in the
SingleHopSpecificQuerySynthesizerdefault name.single_hop_specifc_query_synthesizer->single_hop_specific_query_synthesizer)