feat: add smtp configurations #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyisss
requested review from
Michiel87 and
timrab
and removed request for
a team
xiangyisss
changed the title
xiangyisss
changed the title
There was a problem hiding this comment.
Pull Request Overview
Introduce SMTP and logfiles configuration options and wire them into the Helm chart for the proximity and pigeon components.
- Add
smtp.mailandlogfilessections tovalues.yaml - Create SMTP Secret and ConfigMap templates
- Inject logfiles and SMTP settings into CLI, API, and pigeon deployments
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/exivity/values.yaml | Added smtp.mail and logfiles configuration blocks |
| charts/exivity/templates/smtp/smtp-secret.yaml | New Secret template for storing SMTP credentials |
| charts/exivity/templates/smtp/smtp-configmap.yaml | New ConfigMap template for SMTP settings |
| charts/exivity/templates/proximity/logfile.configmap.yaml | New ConfigMap template for logfiles retention/compression |
| charts/exivity/templates/proximity/cli.deployment.yaml | Mounted logfiles ConfigMap in the proximity CLI |
| charts/exivity/templates/proximity/api.deployment.yaml | Mounted SMTP Secret and ConfigMap in the proximity API |
| charts/exivity/templates/pigeon/deployment.yaml | Added SMTP Secret mount in pigeon deployment |
Files not reviewed (1)
- charts/exivity/values.schema.json: Language not supported
…ng deployment references Signed-off-by: Steffen Exler <[email protected]>
…d enhance schema documentation Signed-off-by: Steffen Exler <[email protected]>
… deployment and configmap templates
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
linuxluigi
requested changes
Jun 2, 2025
Signed-off-by: Steffen Exler <[email protected]>
Signed-off-by: Steffen Exler <[email protected]>
linuxluigi
changed the title
linuxluigi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce proximity options and configurations for SMTP, enhancing the application's flexibility in handling email management.
See: https://exivity.atlassian.net/browse/EXVT-5992