fix: properly quote reserved keyword columns in snapshot unique_key #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper column quoting for Exasol snapshots when unique_key or
updated_at columns use reserved SQL keywords (TIME, DATE, USER, etc).
- Add exasol__quote_column helper macro that:
- Passes through already-quoted columns ("time" → "time")
- Uppercases and quotes unquoted columns (field_id → "FIELD_ID")
- Add exasol__build_scd_args to build properly quoted scd_id arguments
- Override snapshot_timestamp_strategy for proper quoting
- Add exasol__snapshot_check_strategy with proper quoting for check cols
- Add exasol__unique_key_fields macro for dbt_unique_key generation
- Remove | upper filter from snapshot_merge.sql to preserve case
- Add test for reserved keyword handling in composite unique_key
Usage: specify reserved keywords with quotes in YAML config:
unique_key: ['field_id', '"time"']
updated_at: '"date"'
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tglunde,
Please review my changes.
I came across across this issue in my production environment. Some source tables may have reserved keywords as column names and it's not adjustable as transferred 1-1 from upstreaming system.
So I've decided to adjust snapshot logic to be able to process such columns when they are used as identifiers.
Add proper column quoting for Exasol snapshots when unique_key or
updated_at columns use reserved SQL keywords (TIME, DATE, USER, etc).
Usage: specify reserved keywords with quotes in YAML config:
unique_key: ['field_id', '"time"']
updated_at: '"date"'